Gzip compression options#1587
Conversation
Sushisource
force-pushed
the
gzip-compression
branch
2 times, most recently
from
3051a0b to
d5be198
Compare
Sushisource
force-pushed
the
gzip-compression
branch
3 times, most recently
from
5c176a5 to
30388d8
Compare
Sushisource
force-pushed
the
gzip-compression
branch
from
30388d8 to
30d71e6
Compare
| re.compile(r"'__module__' : 'temporal\.api\.").sub, | ||
| r"'__module__' : 'temporalio.api.", | ||
| ), | ||
| partial( |
There was a problem hiding this comment.
This replacement didn't seem to be needed for me, do we know what it's about?
There was a problem hiding this comment.
It doesn't happen for the other dependency, protoc_gen_openapiv2
There was a problem hiding this comment.
It might not be needed, I just followed the pattern for the other replacements w/ the new module name
|
|
||
| _WORFKLOW_LINK_URL_PATH_REGEX = re.compile( | ||
| r"^/namespaces/(?P<namespace>[^/]+)/workflows/(?P<workflow_id>[^/]+)/(?P<run_id>[^/]+)/history$" | ||
| _WORKFLOW_LINK_URL_PATH_REGEX = re.compile( |
There was a problem hiding this comment.
@VegetarianOrc should take a look at these changes.
There was a problem hiding this comment.
Changes look okay to me! Unsure of the context of the new link type or if it's related to the gzip changes, but the conversion looks good and I appreciate the new helper functions
There was a problem hiding this comment.
Not related to the gzip changes, just wanted to fix the lint
3 participants
What was changed
Update core & expose options for gzip compression.
Also proto regen required a few other changes to deal with new Nexus things.
Why?
Options good!
Checklist
Closes
How was this tested:
Relies on Core tests for the meat of it. Simple tests to verify options are passed thru.
Any docs updates needed?